Skip to content

[New Feature] Screenshot of Slide#496

Merged
birm merged 3 commits intocamicroscope:developfrom
Hemansh31:screenShot
Feb 22, 2021
Merged

[New Feature] Screenshot of Slide#496
birm merged 3 commits intocamicroscope:developfrom
Hemansh31:screenShot

Conversation

@Hemansh31
Copy link
Copy Markdown
Contributor

@Hemansh31 Hemansh31 commented Feb 19, 2021

Description

**Describe your changes in detail

This screenshot feature helps user to take screenshot of the slide along with annotations and download it as an image.

Motivation and Context

*Why is this change required? What problem does it solve?

This is useful as screenshots of slides are required by several users as they need to be included in reports or research papers.
Note :
This is the first and basic version of screen capture. Next step in this includes adding functionality to capture only a selected area of the slide.
This is the same PR as #493

How Has This Been Tested?

**Please describe in detail how you tested your changes.

I tested it on my local setup

Screenshots (if appropriate):

Untitled_ Feb 19, 2021 8_32 AM

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@birm birm requested a review from nanli-emory February 19, 2021 05:44
Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, could you add a record to the readme, as this is a new button. Also, I think this warrants a history.md addition, but if you don't want to add it now, I'll add it at the next release.

Thank you @Hemansh31, I'm sure people will like this addition!

@Hemansh31
Copy link
Copy Markdown
Contributor Author

@birm I have updated the Readme.md file and History.md file

Copy link
Copy Markdown
Member

@nanli-emory nanli-emory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW ~~~~ a nice new feature, thanks @Hemansh31

@birm birm merged commit c74cbff into camicroscope:develop Feb 22, 2021
This was referenced Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants