Regex validation for email during signup process#501
Merged
birm merged 1 commit intocamicroscope:developfrom Mar 16, 2021
Merged
Regex validation for email during signup process#501birm merged 1 commit intocamicroscope:developfrom
birm merged 1 commit intocamicroscope:developfrom
Conversation
birm
approved these changes
Mar 16, 2021
Member
birm
left a comment
There was a problem hiding this comment.
Thank you, this should hopefully help avoid some confusion
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
** Regex validation for email in the signup form. The program throws an alert and doesn't proceed to registration.
Motivation and Context
** During user registration, it is possible currently to sign up with an invalid email. I felt adding an email validation with a tried and tested regular expression so the form doesn't accept invalid email might be a good addition.
How Has This Been Tested?
** The regex is based on RFC822 standard, so it covers the entire spectrum of email addresses. I have used the regex from w3resources. So it is expected to work right.
I tested the same code with camicroscope. It works for all the cases. I have used the same code in my earlier projects and it has never caused an issue.
Types of changes
Checklist: