Update bootstrap in table.html, workbench.html and info.html#519
Update bootstrap in table.html, workbench.html and info.html#519birm merged 2 commits intocamicroscope:developfrom
Conversation
|
Hey @birm, Is this PR okay? |
|
Hoping to review soon :) |
|
Sure. Thanks |
|
It looks like the slide upload button/modal isn't working among similar issues, does this match your observation? |
|
Bootstrap 5 is major bump in bootstrap because it has ditched jQuery completely. And camic uses jquery a lot this needs to tested quite extensively I suppose. |
Addition: Workbench uses mdbootstrap so and it has bootstrap 4 as dependency I guess. So things should be tested carefully not just from a UI perspective but from a workflow perspective too. |
|
Hey, I am also looking into the issue, the problem I am facing is only the slide upload button is not calling the on-click functions. I don't know if the problem is with bootstrap 5 as other buttons are working. |
|
Luckily, this isn't blocking anything, so we have plenty of time to test! |
Great |
|
I am on it. |
|
Hey guys, Things are working fine now... Apparently, bootstrap have updated a few things: |
Summary
Issue: #517
I have updated the bootstrap versions in workbench.html, info.html, table.html files.
Motivation
Testing
Questions