Providing each Wayland interface instance with access to their client#4860
Open
mattkae wants to merge 3 commits intowayland-rs-global-filterfrom
Open
Providing each Wayland interface instance with access to their client#4860mattkae wants to merge 3 commits intowayland-rs-global-filterfrom
mattkae wants to merge 3 commits intowayland-rs-global-filterfrom
Conversation
mattkae
force-pushed
the
wayland-rs-global-filter
branch
from
5862a79 to
9df6ce8
Compare
mattkae
force-pushed
the
wayland-rs-client-per-object
branch
from
2ea9b28 to
3c85bea
Compare
tarek-y-ismail
approved these changes
Apr 24, 2026
Contributor
tarek-y-ismail
left a comment
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Pokes here and there, but fine otherwise.
Comment on lines
+416
to
+418
| self.protected_constructor_args | ||
| .last_mut() | ||
| .expect("protected_constructor_args cannot be empty after push") |
Contributor
There was a problem hiding this comment.
Kinda redundant to check right after pushing. What is this trying to assert?
Comment on lines
+162
to
+165
| format!( | ||
| "{} {}", | ||
| cpp_arg_type_to_cpp_source(&arg.cpp_type, true), | ||
| arg.name |
Contributor
There was a problem hiding this comment.
I think I've seen this pattern before while reviewing related code. Might be worth refactoring out at some point (not urgent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
Checklist