Don't allow subsurface parent-child loops#4881
Open
robert-ancell wants to merge 7 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds protocol-level validation to wl_subcompositor.get_subsurface to prevent clients from creating invalid subsurface parent relationships (including obvious self-parenting).
Changes:
- Rejects
get_subsurfacewhen the child surface is the same resource as the parent. - Adds a check intended to prevent parent/child cycles by rejecting certain parent choices before creating the
WlSubsurface.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/canonical/mir/sessions/d394a7de-811d-491e-945c-4e077e3eab2f Co-authored-by: robert-ancell <126560+robert-ancell@users.noreply.github.com>
Agent-Logs-Url: https://github.com/canonical/mir/sessions/d394a7de-811d-491e-945c-4e077e3eab2f Co-authored-by: robert-ancell <126560+robert-ancell@users.noreply.github.com>
RAOF
requested changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.