fix: race condition when creating standard logger #68
Merged
aymanbagabas merged 1 commit intomainfrom Aug 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 76.85% 77.49% +0.64%
==========================================
Files 10 10
Lines 635 631 -4
==========================================
+ Hits 488 489 +1
+ Misses 132 128 -4
+ Partials 15 14 -1
|
aymanbagabas
force-pushed
the
write-race
branch
from
755c7dd to
cf2a8bd
Compare
aymanbagabas
changed the title
caarlos0
approved these changes
Aug 1, 2023
Before, `StandardLog` used to _copy_ the internal buffer causing two or more loggers to share the same buffer triggering a race. Don't copy the internal buffer and reduce the mutex critical section scope.
aymanbagabas
force-pushed
the
write-race
branch
from
cf2a8bd to
8254a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before,
StandardLogused to copy the internal buffer causing two ormore loggers to share the same buffer triggering a race.
Don't copy the internal buffer and reduce the mutex critical section
scope.
Fixes: #67