Fix JRuby test suite: OpenSSL 3 expired certs, TLS 1.3 mTLS, DER key parsing#119
Merged
kares merged 1 commit intocheald:masterfrom Oct 20, 2025
Merged
Fix JRuby test suite: OpenSSL 3 expired certs, TLS 1.3 mTLS, DER key parsing#119kares merged 1 commit intocheald:masterfrom
kares merged 1 commit intocheald:masterfrom
Conversation
Contributor
jsvd
commented
Sep 2, 2025
jsvd
commented
- OpenSSL 3 compatibility: stop relying on negative/zero -days for expired cert fixtures (rejected by OpenSSL 3, preventing local running of tests on MacOS). Synthesize an expired self‑signed cert at runtime in the test helper
- TLS 1.3 interop: work around mTLS handshake timeouts with JRuby on JDK 21 by disabling TLSv1.3 on the WEBrick SSL test server
- PKCS#8 key parsing: do not chomp decoded DER. Trimming binary DER can remove trailing newline bytes and corrupt the key, causing InvalidKeySpecException (covered by an existing test)
…parsing * OpenSSL 3 compatibility: stop relying on negative/zero -days for expired cert fixtures (rejected by OpenSSL 3, preventing local running of tests on MacOS). Synthesize an expired self‑signed cert at runtime in the test helper * TLS 1.3 interop: work around mTLS handshake timeouts with JRuby on JDK 21 by disabling TLSv1.3 on the WEBrick SSL test server * PKCS#8 key parsing: do not chomp decoded DER. Trimming binary DER can remove trailing newline bytes and corrupt the key, causing InvalidKeySpecException (covered by an existing test)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.