Move mypy configuration into pyproject.toml#935
Merged
cjolowicz merged 3 commits intocjolowicz:mainfrom Jun 15, 2021
yeskunall:feat-mypy-use-pyproject-917
Merged
Move mypy configuration into pyproject.toml#935cjolowicz merged 3 commits intocjolowicz:mainfrom yeskunall:feat-mypy-use-pyproject-917
mypy configuration into pyproject.toml#935cjolowicz merged 3 commits intocjolowicz:mainfrom
yeskunall:feat-mypy-use-pyproject-917
Conversation
cjolowicz
reviewed
Jun 15, 2021
Owner
cjolowicz
left a comment
cjolowicz
left a comment
There was a problem hiding this comment.
Sweet, thanks!
I'll merge the Dependabot update for mypy first, will ping you to rebase when that's done.
Update: It turns out that we need to update sphinx-click first, then click, then mypy (while installing types-click into the mypy session).
Owner
|
@yeskunall Can you rebase on master? It's already on the latest mypy version. Update: Never mind, already merged master into your branch. |
Merged
Contributor
Author
|
@cjolowicz you move quickly! Just got off work to see this has already been merged and made part of a new release. Once again, thanks for your work on this. I actually first came across your project on awesome-pyproject and then went through your article. Very informative! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for this dope
cookiecuttertemplate. Let me know if I need to make any changes before this can be merged.❤️
Closes #917