Conversation
4 tasks
echappen
reviewed
Apr 22, 2024
echappen
reviewed
Apr 22, 2024
echappen
reviewed
Apr 22, 2024
/v3/organizations /v3/organizations/[guid] /v3/organizations/[guid]/users swaps out actual guids, org names, and user names but otherwise leaves the responses intact
instructs jest to ignore mocks directory adds interface for api org response
echappen
reviewed
Apr 22, 2024
Co-authored-by: Eleni Chappen <eleni.chappen@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fulfills step 2 of #102
__tests__getCFAppsfunction and makes reusable for listing apps and orgsuseUnknownInCatchVariablesfor tsconfig to get around usinganyfor error (see docs)This is an extremely rough implementation of grabbing information about orgs the user has access to. It lacks error handling and jumps straight to the
.resourcesportion of an API response. Now that our users can successfully receive org information from the CF API, we will want to invest time thinking about additional response data we want to use, like pagination / count, understand CF error messages beyond just the returning http code, etc. This will require refactoring in thecloudfoundry.tsfile and possiblyapi.js.The UI is left untested as it is expected to change drastically in the near future.
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
The API requests are available to unauthenticated users, although without a correct token for the CF API they will receive a 401 response.
In the test mock files, I have replaced all GUIDs, usernames, org names, etc to make for a generic but realistic API response.