Skip to content

Reworked Vert.x Integration#129

Merged
slinkydeveloper merged 4 commits intocloudevents:masterfrom
slinkydeveloper:vertx
Apr 24, 2020
Merged

Reworked Vert.x Integration#129
slinkydeveloper merged 4 commits intocloudevents:masterfrom
slinkydeveloper:vertx

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Member

@slinkydeveloper slinkydeveloper commented Apr 23, 2020 •
edited
Loading

Fix #112

Supersede #107, #104, #116

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Apr 23, 2020
@slinkydeveloper slinkydeveloper requested a review from matzew April 23, 2020 16:43
@matejvasek
Copy link
Copy Markdown
Contributor

matejvasek commented Apr 23, 2020

While testing I found out that headers are case sensitive. For instance if I curl with -H "Ce-Id: 42" the id is not read. Maybe we should pre-process headers with toLowerCase().

@slinkydeveloper
Copy link
Copy Markdown
Member Author

slinkydeveloper commented Apr 23, 2020

That's weird, MultiMap#get should be case-insensitive

@slinkydeveloper
Copy link
Copy Markdown
Member Author

slinkydeveloper commented Apr 23, 2020 •
edited
Loading

@matejvasek can you post the test code you wrote? Is the problem on the client or on the sender?

matejvasek
matejvasek reviewed Apr 23, 2020
View reviewed changes
Comment thread http/vertx/src/main/java/io/cloudevents/http/vertx/impl/BinaryVertxMessageImpl.java Outdated
@slinkydeveloper
Copy link
Copy Markdown
Member Author

slinkydeveloper commented Apr 23, 2020

@matejvasek fixed, now it works 😄

@slinkydeveloper slinkydeveloper mentioned this pull request Apr 24, 2020
Closed
@slinkydeveloper
Started http-vertx module reworking
54821e9 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Vertx integration done
3c12a16 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Adjusted the READMEs
13bc101 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Case sensitivity fix
8d09196 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@matzew
Copy link
Copy Markdown
Member

matzew commented Apr 24, 2020

/lgtm
/approve

@slinkydeveloper slinkydeveloper merged commit 2b5e72c into cloudevents:master Apr 24, 2020
@slinkydeveloper slinkydeveloper deleted the vertx branch April 24, 2020 10:17
@slinkydeveloper slinkydeveloper added this to the 2.0.0-milestone1 milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew Awaiting requested review from matzew

1 more reviewer

@matejvasek matejvasek matejvasek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.0.0-milestone1

Development

Successfully merging this pull request may close these issues.

Modularization: http-vertx module

3 participants

@slinkydeveloper @matejvasek @matzew