Enable configuration of sub-second precision of timestamps#54
Merged
GrahamCampbell merged 1 commit intocloudevents:mainfrom Dec 18, 2023
GrahamCampbell:configurable-subsecond-precision
Merged
Enable configuration of sub-second precision of timestamps#54GrahamCampbell merged 1 commit intocloudevents:mainfrom GrahamCampbell:configurable-subsecond-precision
GrahamCampbell merged 1 commit intocloudevents:mainfrom
GrahamCampbell:configurable-subsecond-precision
Conversation
Signed-off-by: Graham Campbell <hello@gjcampbell.co.uk>
jlaswell
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the configuration of the sub-second precision in serialized timestamps. None of these changes are breaking because either the changes are made to classes marked as internal or a new constructor added to a final class with all parameters optional, and the default precision remains unchanged.
Example usage, serializing a cloudevent timestamp including the milliseconds but not the microseconds:
Note that on the deserialisation side of the house, we already can handle sub-second timestamps of any precision, truncating down to at most 6 digits, as supported by PHP, without any configuration.