Conversation
aron-cf
requested review from
ghostwriternr,
scuffi and
whoiskatrin
as code owners
🦋 Changeset detectedLatest commit: 7dfe5fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| Introduce new `rpc` transport to consolidate `http` and `websocket` transports. | ||
|
|
||
| The intention is to replace `http` and `websocket` transports with a single implementation. | ||
|
|
||
| - No sub-request limitations (currently affects the `http` transport). | ||
| - No limit on write file size (currently affects both `http` and `websocket` transports). | ||
|
|
||
| To enable the transport set `SANDBOX_TRANSPORT` to `rpc` in your wrangler config. | ||
|
|
||
| A `ReadableStream` instance can now be passed to `sandbox.writeFile()` when using the `rpc` transport to avoid the 32mb file limit. |
There was a problem hiding this comment.
🟡 Changeset violates AGENTS.md rule: content exceeds single paragraph limit
The AGENTS.md rule at line 344 states: "Keep it short. Each changeset entry should aim to be a couple of sentences, no more than a single paragraph." The changeset in .changeset/introducing-rpc-transport.md contains four separate paragraphs of prose plus a bullet list (in addition to the code example). This is far more than the mandated single paragraph. The "Good" example in AGENTS.md:352-355 demonstrates a two-sentence format. The changeset text (lines 5-14, excluding the code block) should be condensed into a single short paragraph.
| Introduce new `rpc` transport to consolidate `http` and `websocket` transports. | |
| The intention is to replace `http` and `websocket` transports with a single implementation. | |
| - No sub-request limitations (currently affects the `http` transport). | |
| - No limit on write file size (currently affects both `http` and `websocket` transports). | |
| To enable the transport set `SANDBOX_TRANSPORT` to `rpc` in your wrangler config. | |
| A `ReadableStream` instance can now be passed to `sandbox.writeFile()` when using the `rpc` transport to avoid the 32mb file limit. | |
| New `rpc` transport removes sub-request limitations and file size limits. Set `SANDBOX_TRANSPORT` to `rpc` in your wrangler config to enable. A `ReadableStream` can now be passed to `sandbox.writeFile()` to stream large files. | |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
|
||
| Introduce new `rpc` transport to consolidate `http` and `websocket` transports. | ||
|
|
||
| The intention is to replace `http` and `websocket` transports with a single implementation. |
There was a problem hiding this comment.
🟡 Changeset violates AGENTS.md rule: includes internal technical implementation details
The AGENTS.md rule at line 343 states: "Focus on the problem solved and the benefit, not technical implementation details." Line 7 of the changeset — "The intention is to replace http and websocket transports with a single implementation" — describes an internal implementation strategy (consolidating transports) rather than a user-facing benefit. This mirrors the "Bad" example in AGENTS.md:349-350 ("Add WebSocket transport for request multiplexing over a single connection") which is also flagged as technical/internal-focused.
Was this helpful? React with 👍 or 👎 to provide feedback.
3 participants
Uh oh!
There was an error while loading. Please reload this page.