Conversation
Contributor
Author
|
Confirmed fixes #465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once upon a time, a young graduate student (who had not taken a compiler course previously) found a reason to use Bison and Flex, and was very proud of himself for having done so.
Unfortunately he also forgot to free some memory in various error handling conditions, which, as noted in the Bison documentation, is not one of the many applications where memory leaks are quite acceptable (you will not be surprised that this pearl of wisdom originates with the designer of C++).
So free that memory (tested with valgrind, but not all of the conditions are easy to trigger...)
Fixes: #465