Skip to content

feature: ssh access to git repository#92

Closed
ast9501 wants to merge 7 commits intocoder:mainfrom
ast9501:feature/git-ssh
Closed

feature: ssh access to git repository#92
ast9501 wants to merge 7 commits intocoder:mainfrom
ast9501:feature/git-ssh

Conversation

@ast9501
Copy link
Copy Markdown

@ast9501 ast9501 commented Feb 19, 2024

Allow using private key to access repositories.

- Build-in (or mount) private key in envbuilder image for access repository
@matifali matifali requested review from aaronlehmann and kylecarbs and removed request for kylecarbs March 30, 2024 11:17
Comment thread envbuilder.go Outdated
Comment thread go.mod Outdated
Comment thread git.go
Comment thread envbuilder.go Outdated
Comment thread envbuilder.go Outdated
Comment thread envbuilder.go Outdated
Comment thread envbuilder.go
Comment thread envbuilder.go Outdated
Comment thread envbuilder.go Outdated
Comment thread envbuilder.go
Copy link
Copy Markdown
Author

@ast9501 ast9501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some commits for fix/improve some problems according to comment message.

Comment thread go.mod Outdated
Comment thread git.go
Comment thread envbuilder.go
Comment thread README.md
```

### PrivateKey-based authentication
* Prebuild private key in your envbuilder image
Copy link
Copy Markdown

@ggjulio ggjulio Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this dangerous if we use a cache registry ?
The layer containing the private key may end up in the registry, or am I missing something ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original assumption was that this image may be stored in a private registry, so I didn't take into consideration the potential issue of having a private key in the image layers.

@unValerio
Copy link
Copy Markdown

Is there any other way as of right now to clone a private repository?

@ast9501
Copy link
Copy Markdown
Author

ast9501 commented Sep 12, 2024

Is there any other way as of right now to clone a private repository?

Maybe you can reference to README doc, there are some guides to access to different kind of git (also for private repository):
https://github.com/coder/envbuilder?tab=readme-ov-file#git-authentication

@ast9501 ast9501 closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants