fix: insert full file path when selecting file in directory tree#260
Closed
a3ng7n wants to merge 9 commits intocoderamp-labs:mainfrom
Closed
fix: insert full file path when selecting file in directory tree#260a3ng7n wants to merge 9 commits intocoderamp-labs:mainfrom
a3ng7n wants to merge 9 commits intocoderamp-labs:mainfrom
Conversation
Contributor
|
@a3ng7n The tests are failing. Can you have a look at it? |
Contributor
Author
|
Will do! Need a little to get back to a computer. |
Contributor
|
Thanks for your efforts. However, I am closing as this has already been addressed in #295. |
Contributor
Author
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(includes changes from #259 )
This makes clicking on a file in the directory structure insert the full file path to the include/exclude pattern. It does this by changing the output of
_create_tree_structurefrom a single newline delimited string, to a list of those same lines, in tuples with the corresponding file path they represent.The api interface that the user sees for
ingest_queryandformat_nodeis kept the same; they both still output a tuple of three strings. But there's some added lifting toprocess_queryto regenerate the context-aware directory tree, and use that within the html/js interaction functions. To eliminate this regeneration would mean either a very different architecture or changing the interfaces foringest_queryandformat_node, both of which didn't seem like the right call.keeping this as draft until if/when #259 gets merged