feat: Add AccountAllBalances API endpoint#533
Merged
jacquescaocb merged 1 commit intocoinbase:masterfrom Dec 8, 2025
Merged
Conversation
✅ Heimdall Review Status
|
jacquescaocb
force-pushed
the
add-account-all-balances-api
branch
2 times, most recently
from
d388654 to
116c982
Compare
….7.1 This commit consolidates all changes for the AllAccountBalances feature and Check-Gen issue resolution: ## New Features - Add AllAccountBalances API endpoint (/account/all_balances) - Enables fetching all sub-account balances in a single request - Reduces network overhead and ensures consistent block context - Add AccountBalanceWithSubAccount type for structured responses ## API Changes - Add AllAccountBalancesRequest and AllAccountBalancesResponse types - Add AllAccountBalances methods to client, fetcher, and server - Update asserter with validation for new endpoint ## Infrastructure Updates - Update to mesh-specifications v1.7.1 (latest) - Remove replace directive to use remote types v1.7.1 - Keep local types directory for development - Fix codegen.sh to use standard remote download - Restore AccountBalanceWithSubAccount.SubAccountIdentifier field ## Bug Fixes - Fix Check-Gen issue with missing SubAccountIdentifier - Fix URL naming consistency (kebab-case) - Add ConstructionPreprocessOperations API support ## Testing - All tests pass except one unrelated headerforwarder test - Check-Gen now correctly detects differences - Go build succeeds with remote dependencies
jacquescaocb
force-pushed
the
add-account-all-balances-api
branch
from
116c982 to
9f01272
Compare
jingweicb
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AllAccountBalances API and Fix URL Naming Consistency
Overview
This PR integrates the new AllAccountBalances API from Rosetta specification v1.7.1 and fixes URL naming consistency issues across all Construction and Account endpoints.
Changes
1. AllAccountBalances API Integration
New Endpoint:
POST /account/all-balancesAdds complete implementation for the AllAccountBalances API that consolidates multiple sub-account balance queries into a single request.
Components Added:
AllAccountBalancesRequest,AllAccountBalancesResponse,AccountBalanceWithSubAccountclient/api_account.goserver/api_account.gofetcher/account.goKey Features:
2. URL Naming Consistency Fix
Updated all endpoints to use kebab-case consistently:
/account/all_balances→/account/all-balances/construction/preprocess_operations→/construction/preprocess-operationsFiles Updated:
client/api_account.go- Client endpoint pathsclient/api_construction.go- Client endpoint pathsserver/api_account.go- Server route definitionsserver/api_construction.go- Server route definitionstypes/- Documentation references in type definitions