test(cli): import inquirerer test utils directly from @inquirerer/test#1027
Merged
pyramation merged 1 commit intomainfrom Apr 26, 2026
Merged
test(cli): import inquirerer test utils directly from @inquirerer/test#1027pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
The local 'packages/cli/test-utils' barrel was a pure passthrough re-export of @inquirerer/test, which made it look like there was a custom test harness when there wasn't. This points cli.test.ts at @inquirerer/test directly so it's obvious where the helpers come from, and trims test-utils/index.ts down to the genuinely local fixture helpers. No behavioural change — the symbols (KEY_SEQUENCES, setupTests, TestEnvironment) are identical.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
packages/cli/test-utils/index.tsbarrel was a pure passthrough re-export of@inquirerer/test, which made it look like there was a custom test harness when there wasn't. This makescli.test.tsimport from@inquirerer/testdirectly so the source is obvious, and trimstest-utils/index.tsdown to the genuinely local fixture helpers.No behavioural change — the symbols are identical (the local barrel was just
export { ... } from '@inquirerer/test').test-utils/fixtures.tsstays put because it's a genuinely local wrapper aroundcreateTestFixture.Review & Testing Checklist for Human
pnpm --filter @constructive-io/cli teststill passes locally (with@constructive-io/graphql-codegenbuilt — bothcli.test.tsandcodegen.test.tsshould be green).packages/cli/test-utilsimports got broken — confirmed via grep, onlycli.test.tsreferenced this path.Notes
Companion PR:
constructive-io/dev-utils#79adds arunClisubprocess helper to@inquirerer/testand a Testing section to inquirerer's main README pointing at the package. This PR is independent of that one (it just uses the existing in-processsetupTestsAPI), but they're part of the same "make CLI testing easy and discoverable" thread.A separate downstream PR will follow in
constructive-io/agentic-dbto swap the hand-rolledrunCliincli-e2e-testsfor the new shared helper once dev-utils#79 lands.Link to Devin session: https://app.devin.ai/sessions/81001448b7c54b8099437f706d44a30d
Requested by: @pyramation