[upstream-sync] Port upstream PR #970: add "timeout" to ToolResultType#80
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
[upstream-sync] Port upstream PR #970: add "timeout" to ToolResultType#80github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add :timeout/:"timeout" to the ::result-type spec, matching the upstream addition of "timeout" as a valid resultType value for structured tool results (ToolResultObject). Upstream PR: github/copilot-sdk#970 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports changes from upstream
github/copilot-sdkPR #970: Pass structured tool results via RPC instead of stringifying.Upstream Changes Ported
PR #970 — adds
"timeout"as a validToolResultTypevalue:types.ts:ToolResultTypeextended with"timeout":"success" | "failure" | "rejected" | "denied"→"success" | "failure" | "rejected" | "denied" | "timeout"session.ts: AddedisToolResultObjecttype guard so structuredToolResultObjectvalues are passed directly via RPC instead of being JSON-stringified (the Clojure SDK already had equivalent behavior vianormalize-tool-result).Clojure changes
src/github/copilot_sdk/specs.clj: Added:timeoutand"timeout"to::result-typespec set.CHANGELOG.md: Added entry under[Unreleased]→### Changed (v0.2.1 sync).Note: The
isToolResultObjectstructured pass-through behavior (the other half of PR #970) was already correctly implemented in the Clojure SDK'snormalize-tool-resultfunction insession.clj. No change needed there.Upstream Changes Skipped
Testing
Tests could not run in this environment (Maven dependencies unavailable, network access blocked). The change is a one-line addition of
"timeout"to an existing set literal inspecs.clj— structurally identical to the existing entries.