Load yaml files using the failsafe schema option#226
Merged
crazy-max merged 2 commits intocrazy-max:masterfrom Jan 30, 2025
pjpires:yaml-failsafe-schema
Merged
Load yaml files using the failsafe schema option#226crazy-max merged 2 commits intocrazy-max:masterfrom pjpires:yaml-failsafe-schema
crazy-max merged 2 commits intocrazy-max:masterfrom
pjpires:yaml-failsafe-schema
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures we load the YAML file containing the labels declaration using the FAILSAFE_SCHEMA option from js-yaml (docs). This means only strings, arrays and plain objects can be present in the loaded document.
@crazy-max, I've added a new fixture file containing several examples to cover the different fields currently available. Please, let me know if you can think of additional examples that would be useful to include.
Fixes #221.