Fixed VariableFacadeLoadRunnerImpl setVariable method…#113
Merged
sergeytrasko merged 2 commits intoctco:masterfrom Dec 1, 2017
Andrey-Suprun:master
Merged
Fixed VariableFacadeLoadRunnerImpl setVariable method…#113sergeytrasko merged 2 commits intoctco:masterfrom Andrey-Suprun:master
sergeytrasko merged 2 commits intoctco:masterfrom
Andrey-Suprun:master
Conversation
…t variables from feature steps
sergeytrasko
reviewed
Dec 1, 2017
|
|
||
| @Override | ||
| public void setVariable(final String name, final String value) { | ||
| if (!value.equals("null")) { |
Member
There was a problem hiding this comment.
Better swap variable and constant. I.e.:
if (!"null".equals(value)) {
...
}
…t variables from feature steps - pull request review comments
sergeytrasko
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to correctly put variables from feature steps