Turn on ServerComputer instances if they have timed out#457
Open
SquidDev wants to merge 1 commit intodan200:masterfrom
Open
Turn on ServerComputer instances if they have timed out#457SquidDev wants to merge 1 commit intodan200:masterfrom
SquidDev wants to merge 1 commit intodan200:masterfrom
Conversation
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…omputer-reload Turn on ServerComputer instances if they have timed out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving parts of #95. It is not a complete solution. Namely, it solves the case where a server is running but has no one online.
Diagnosis
When a server has no players, some chunks (and so their tile entities) are kept alive but are not ticked. Consequently, each computer tile's
ServerComputertimes out and is removed from the registry.When the chunk starts to tick again, the tile tries to find the
ServerComputer. But, as this no longer exists, it creates a new one. However, it does not turn on this new computer (as them_startOnflag isfalse) and so the computer remains off.Solution
We add an additional flag
m_freshwhich determines whether a newServerComputerhas just been created. If so (and the computer was previously on) then this new computer will also be turned on when required.Further notes
This shares some similarities with SquidDev-CC/CCTweaks#136. Whilst the fix implemented there is different, it should also fix this one (and vice versa).