Only send terminal state to interacting players#479
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
Only send terminal state to interacting players#479SquidDev wants to merge 2 commits intodan200:masterfrom
SquidDev wants to merge 2 commits intodan200:masterfrom
Conversation
This splits the computer state (blinking, label, etc...) and terminal state into two separate packets. When a computer changes, the computer state is sent to all players and the terminal state is sent to players who are curerntly using the computer. This reduces network usage by a substantial amount.
Previously they were not marked as such, meaning computer state was not broadcast to the client until blinking state changed.
|
Can one of the admins verify this patch? |
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…network-optimisations Only send terminal state to interacting players
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the computer state (blinking, label, etc...) and terminal state into two separate packets. When a computer changes, the computer state is sent to all players and the terminal state is sent to players who are currently using the computer. This reduces network usage by a substantial amount.
CCTweaks has employed a similar optimisation for a while now, and not seen any adverse effects.
There are several further optimisations which could be implemented (such as only sending regions of the terminal which have changed) but that is not within the scope of this PR.