Prevent turtles moving beyond the world border#520
Open
SquidDev wants to merge 1 commit intodan200:masterfrom
Open
Prevent turtles moving beyond the world border#520SquidDev wants to merge 1 commit intodan200:masterfrom
SquidDev wants to merge 1 commit intodan200:masterfrom
Conversation
As tiles outside the world border are not ticked, turtles are rendered entirely useless. Furthermore, the turtle animation will never progress resulting in visual glitches. In order to avoid this, we ensure the target position is within the world border when moving to it.
Lupus590
reviewed
Feb 12, 2018
| import dan200.computercraft.shared.util.WorldUtil; | ||
| import net.minecraft.block.Block; | ||
| import net.minecraft.entity.Entity; | ||
| import net.minecraft.util.EnumFacing; |
Contributor
There was a problem hiding this comment.
Why was this line moved? I assume the move has no effect and just makes the commit a bit messy.
Contributor
Author
There was a problem hiding this comment.
Because my IDE likes to put things in alphabetical order. I'm going to be honest, I can't really muster the energy to fix it.
|
Can one of the admins verify this patch? |
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…urtle-world-border Prevent turtles moving beyond the world border
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As tiles outside the world border are not ticked, turtles are rendered entirely useless. Furthermore, the turtle animation will never progress resulting in visual glitches.
In order to avoid this, we ensure the target position is within the world border when moving to it.