Fix #11617 FP constParameter with std::begin/end#8427
Open
chrchr-github wants to merge 19 commits intodanmar:mainfrom
Open
Fix #11617 FP constParameter with std::begin/end#8427chrchr-github wants to merge 19 commits intodanmar:mainfrom
chrchr-github wants to merge 19 commits intodanmar:mainfrom
Conversation
danmar
reviewed
Apr 11, 2026
lib/symboldatabase.cpp
Outdated
| const Token* varTok = tok->astOperand2(); | ||
| while (Token::simpleMatch(varTok, "[")) | ||
| varTok = varTok->astOperand1(); | ||
| if (Token::simpleMatch(varTok, ".")) |
Owner
There was a problem hiding this comment.
I suggest replace the if with while
lib/symboldatabase.cpp
Outdated
| varTok = varTok->astOperand1(); | ||
| if (Token::simpleMatch(varTok, ".")) | ||
| varTok = varTok->astOperand2(); | ||
| const auto* const paramVariable = varTok->variable(); |
Owner
There was a problem hiding this comment.
I assume varTok could become null here. personally I prefer the actual type Variable instead of auto when it's not super obvious i.e. cast result type..
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.