Skip to content

Enable File-Specific Formatting in dataform format#1754

Merged
Ekrekr merged 3 commits intodataform-co:mainfrom
hiracky16:feature-format-particular-file
Jun 21, 2024
Merged

Enable File-Specific Formatting in dataform format#1754
Ekrekr merged 3 commits intodataform-co:mainfrom
hiracky16:feature-format-particular-file

Conversation

@hiracky16
Copy link
Copy Markdown
Contributor

@hiracky16 hiracky16 commented Jun 3, 2024

resolve #1747
before my pr: #1746

@hiracky16
Copy link
Copy Markdown
Contributor Author

hiracky16 commented Jun 3, 2024

Hi @Ekrekr .
I ran the tests, but the following error occurred. It seems like there might be a permission issue. Do you know what might be causing this?

I'm experiencing the same error as this #1751

ERROR: /Users/xxx/workspace/dataform/test_credentials/BUILD:5:14: Action test_credentials/bigquery.json failed: (Exit 1): gcloud failed: error executing command external/gcloud_sdk/bin/gcloud kms decrypt '--ciphertext-file=test_credentials/bigquery.json.enc' '--plaintext-file=bazel-out/darwin-py2-fastbuild/bin/test_credentials/bigquery.json' ... (remaining 4 arguments skipped)
ERROR: (gcloud.kms.decrypt) PERMISSION_DENIED: Permission 'cloudkms.cryptoKeyVersions.useToDecrypt' denied on resource 'projects/dataform-open-source/locations/global/keyRings/dataform-builder-keyring/cryptoKeys/dataform-builder-key' (or it may not exist).
INFO: Elapsed time: 6.105s, Critical Path: 4.72s
INFO: 15 processes: 15 internal.
FAILED: Build did NOT complete successfully

@Ekrekr
Copy link
Copy Markdown
Contributor

Ekrekr commented Jun 3, 2024

The permissions grant must not have worked!

Bear with me, I'll test this against my personal GCloud account - but need to be with my personal laptop to do that.

@Ekrekr
Copy link
Copy Markdown
Contributor

Ekrekr commented Jun 4, 2024

Sorry, you won't be able to run these commands yet - there are some privacy and compliance exceptions I need to investigate.

@hiracky16
Copy link
Copy Markdown
Contributor Author

@Ekrekr
Understood the current situation. Please investigate. 🙏

@hiracky16
Copy link
Copy Markdown
Contributor Author

@Ekrekr
I have been waiting for a response for a week.
Could you please let me know approximately how much longer I should expect to wait?
I appreciate your assistance.

@Ekrekr
Copy link
Copy Markdown
Contributor

Ekrekr commented Jun 21, 2024

@Ekrekr I have been waiting for a response for a week. Could you please let me know approximately how much longer I should expect to wait? I appreciate your assistance.

Sorry, the process here is killing me.

I've manually tested it for you, and I'll merge it now. Thanks for contributing!

@Ekrekr Ekrekr merged commit 41e05de into dataform-co:main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable File-Specific Formatting in dataform format

2 participants