Skip to content

View config as protos, via a new class#1760

Merged
Ekrekr merged 12 commits intomainfrom
add-view-config-action
Jun 28, 2024
Merged

View config as protos, via a new class#1760
Ekrekr merged 12 commits intomainfrom
add-view-config-action

Conversation

@Ekrekr
Copy link
Copy Markdown
Contributor

@Ekrekr Ekrekr commented Jun 25, 2024

No description provided.

@Ekrekr Ekrekr changed the title Add view config action, remove JS interfaces for it Add view config action, remove JS interfaces for SQLX config options Jun 25, 2024
@Ekrekr Ekrekr mentioned this pull request Jun 25, 2024
@Ekrekr Ekrekr changed the title Add view config action, remove JS interfaces for SQLX config options View config as protos, via a new class Jun 27, 2024
@Ekrekr Ekrekr requested a review from DiasDauletov June 28, 2024 10:35
Comment thread core/actions/view.ts

public where(where: Contextable<ITableContext, string>) {
this.table.where(where);
return "";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these methods return empty strings?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's for when you call the JS API when in a SQLX file. E.g. so that publish(...).where(...) doesn't actually alter the underlying SQL.

@Ekrekr Ekrekr requested a review from DiasDauletov June 28, 2024 12:44
@Ekrekr Ekrekr merged commit b3638a8 into main Jun 28, 2024
@Ekrekr Ekrekr deleted the add-view-config-action branch June 28, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants