Skip to content

Local test fix with npm install on cloudbuild#1850

Merged
Tuseeq1 merged 4 commits intomainfrom
local_tests
Sep 30, 2024
Merged

Local test fix with npm install on cloudbuild#1850
Tuseeq1 merged 4 commits intomainfrom
local_tests

Conversation

@Tuseeq1
Copy link
Copy Markdown
Member

@Tuseeq1 Tuseeq1 commented Sep 24, 2024

Moving yarn.lock to old version. This will allow open source contributors to keep developing and testing locally without any changes by simply running "./scripts/run_tests".

Updating "./scripts/run_tests_on_cloudbuild" script to use npm install. This will update yarn.lock file to fetch data from Airlock registry with building from cloud build trigger making sure we are still MOSS complaint.
Using bazel run @nodejs//:npm install using the correct registry that is set in .npmrc file unlike bazel run @nodejs//:yarn that ignores it.

@Tuseeq1 Tuseeq1 requested a review from Ekrekr September 24, 2024 16:59
Copy link
Copy Markdown
Contributor

@Ekrekr Ekrekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Comment thread scripts/publish Outdated
@Tuseeq1 Tuseeq1 merged commit cb4cec4 into main Sep 30, 2024
@Tuseeq1 Tuseeq1 deleted the local_tests branch September 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants