feat: add getContents() for reading external markdown files into table descriptions#2138
Open
AmmanuelT wants to merge 8 commits intodataform-co:mainfrom
Open
feat: add getContents() for reading external markdown files into table descriptions#2138AmmanuelT wants to merge 8 commits intodataform-co:mainfrom
AmmanuelT wants to merge 8 commits intodataform-co:mainfrom
Conversation
Contributor
|
/gcbrun |
kolina
requested changes
Apr 11, 2026
Contributor
kolina
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution!
Overall looks good, I've left some not very big comments to address.
Currently tests are failing due to expired BQ credentials, can you please rebase your PR onto #2139 so I can re-run them?
Contributor
Author
|
Thanks for the comments! Working on the fixes! |
8cf17c1 to
cf359f2
Compare
…n on getContents to include limits
Contributor
Author
|
@kolina ready for another check 🫡 |
kolina
approved these changes
Apr 15, 2026
| const resolvedPath = Path.normalize(Path.join(callerDir,filePath)); | ||
| const absolutePath = nodePath.join(this.rootDir, resolvedPath); | ||
|
|
||
| if (!absolutePath.startsWith(this.rootDir)){ |
Contributor
There was a problem hiding this comment.
I'd add separator to this.rootDir here (if it already doesn't end with it) to make sure that file a/somepath.txt won't be considered inside a/somepath/ folder
Contributor
Author
There was a problem hiding this comment.
I hadn't even considered that, good call! It's been added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1723
Allows users to source table descriptions from external markdown files, keeping .sqlx files smaller and enabling reusable, renderable descriptions across the project.
Usage:
Changes:
Notes: