Skip to content

Use trips as primary unit for filtering, cascade changes upwards, and remove nonexistent association#7

Merged
brookeangel merged 7 commits intomainfrom
trips-as-primary-unit
Dec 1, 2025
Merged

Use trips as primary unit for filtering, cascade changes upwards, and remove nonexistent association#7
brookeangel merged 7 commits intomainfrom
trips-as-primary-unit

Conversation

@brookeangel
Copy link
Copy Markdown
Collaborator

@brookeangel brookeangel commented Nov 26, 2025

Addresses: #6

This PR contains several breaking changes to existing behaviors:

See issue and tests for examples.

@brookeangel brookeangel force-pushed the trips-as-primary-unit branch from cdc6e65 to 35f4720 Compare November 26, 2025 16:27
@brookeangel brookeangel force-pushed the trips-as-primary-unit branch from 35f4720 to 62d74ac Compare November 26, 2025 17:38
@brookeangel brookeangel force-pushed the trips-as-primary-unit branch from 1621f5a to 425ba90 Compare November 26, 2025 18:35
@brookeangel brookeangel changed the title WIP: Trips as primary unit Use trips as primary unit for filtering Nov 26, 2025
@brookeangel brookeangel changed the title Use trips as primary unit for filtering Use trips as primary unit for filtering, cascade changes upwards, and remove nonexistent association Nov 26, 2025
@brookeangel brookeangel marked this pull request as ready for review November 26, 2025 18:57
@brookeangel brookeangel requested review from davidmh and harto November 26, 2025 18:58
Comment thread lib/gtfs_df/feed.rb Outdated
private

def apply_filters(file, filters, original)
# Do not mutate the original
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we avoid mutating here but we do mutate in prune!?

If useful, could we leave it as a comment in the code?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, that is awkward! Let me see if I can better arrange, or if not, leave a comment

Copy link
Copy Markdown
Owner

@davidmh davidmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brookeangel brookeangel merged commit 3e0b7ac into main Dec 1, 2025
4 checks passed
@brookeangel brookeangel deleted the trips-as-primary-unit branch December 1, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants