chore: avatars lod impostor textures#810
Conversation
|
After the CI passes:
|
… into chore/AvatarLODImpostorTextures
… into chore/AvatarLODImpostorTextures
sandrade-dcl
left a comment
There was a problem hiding this comment.
I found an issue with the LOD sprites. I explain it in the previous comment on this PR.
D4rWiNSS
left a comment
There was a problem hiding this comment.
I think we should remove the movement of the sprites in the Y-axis, since it is a bit weird right now, the avatars near you don't move up and down. Other than that it looks good to me! GB!
…ar removal from AvatarsLODController
I was able to fix this issue in this same PR |
|
Managed to fix the "invisible wearables" bug when unlodding an avatar bug in this same PR |
sandrade-dcl
left a comment
There was a problem hiding this comment.
I no longer reproduce the bug of some avatars that stayed with the LOD sprite even if we were near of them.
I think we have to improve the transition between LOD sprites and the 3D models of the avatars, we should review the correct distance with the other avatars to activate/deactivate their LODs, and we should resolve the problem of seeing farest avatars moving with the LOD sprite without any animation. But I know itill be workd that we will be contemplating on future steps, so good work, this feature is taking shape! :)
… into chore/AvatarLODImpostorTextures



issue: https://app.zenhub.com/workspaces/unity-6047bad476c3c0001942ee91/issues/decentraland/unity-renderer/712
Changed avatars LOD Impostor textures to content-server-fetched body snapshots or pre-generated generic snapshots from a texture atlas when the user snapshot cannot be fetched.
Generic snapshots atlas used:

Testing with bots (generic body snapshot lod impostors from atlas)
clientDebug.InstantiateBotsAtCoords(100, 91.2, 151.2, 36, 50)to instantiate 100 bot in the stadium. It may take a little while to load as the bots collections and wearables are being randomized and loaded.Screen.Recording.2021-07-23.at.16.16.26.mov
Testing with real users (content-server fetched body snapshot lod impostor)
Screen.Recording.2021-07-23.at.17.35.19-2.mov
Known Issues
Currently we have 2 known bugs already tracked in specific issues:
Weird rotation and Y position of impostors[Fixed]Incomplete body parts when transitioning from lod[Fixed]