Skip to content

chore: avatars lod impostor textures#810

Merged
pravusjif merged 20 commits intomasterfrom
chore/AvatarLODImpostorTextures
Jul 29, 2021
Merged

chore: avatars lod impostor textures#810
pravusjif merged 20 commits intomasterfrom
chore/AvatarLODImpostorTextures

Conversation

@pravusjif
Copy link
Copy Markdown
Member

@pravusjif pravusjif commented Jul 15, 2021

issue: https://app.zenhub.com/workspaces/unity-6047bad476c3c0001942ee91/issues/decentraland/unity-renderer/712

Changed avatars LOD Impostor textures to content-server-fetched body snapshots or pre-generated generic snapshots from a texture atlas when the user snapshot cannot be fetched.

Generic snapshots atlas used:
avatar-impostors-atlas

Testing with bots (generic body snapshot lod impostors from atlas)

  1. enter https://play.decentraland.zone/index.html?renderer=urn:decentraland:off-chain:renderer-artifacts:chore/AvatarLODImpostorTextures&ENV=zone&position=91,151&ENABLE_AVATAR_LODS
  2. open browser console
  3. run clientDebug.InstantiateBotsAtCoords(100, 91.2, 151.2, 36, 50) to instantiate 100 bot in the stadium. It may take a little while to load as the bots collections and wearables are being randomized and loaded.
Screen.Recording.2021-07-23.at.16.16.26.mov

Testing with real users (content-server fetched body snapshot lod impostor)

  1. enter https://play.decentraland.zone/index.html?renderer=urn:decentraland:off-chain:renderer-artifacts:chore/AvatarLODImpostorTextures&ENV=org&position=-27,60&ENABLE_AVATAR_LODS
  2. Try getting close and far away from the other real users to see their LOD Impostor with their snapshot fetched from the content server. It may be better to test on the realm that has more users in that scene (Explore & Play panel may help for this)
Screen.Recording.2021-07-23.at.17.35.19-2.mov

Known Issues

Currently we have 2 known bugs already tracked in specific issues:

@pravusjif pravusjif added the wip label Jul 15, 2021
@pravusjif pravusjif self-assigned this Jul 15, 2021
@github-actions
Copy link
Copy Markdown
Contributor

@sandrade-dcl
Copy link
Copy Markdown
Contributor

I have just found several cases where the avatars are keeping as flat sprite even if I'm near to them. I don't know how to reproduce it, I found it testing in Wonderzone.

image
image
image

Copy link
Copy Markdown
Contributor

@sandrade-dcl sandrade-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue with the LOD sprites. I explain it in the previous comment on this PR.

Copy link
Copy Markdown
Contributor

@D4rWiNSS D4rWiNSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the movement of the sprites in the Y-axis, since it is a bit weird right now, the avatars near you don't move up and down. Other than that it looks good to me! GB!

@pravusjif
Copy link
Copy Markdown
Member Author

I have just found several cases where the avatars are keeping as flat sprite even if I'm near to them. I don't know how to reproduce it, I found it testing in Wonderzone.

I was able to fix this issue in this same PR

@pravusjif
Copy link
Copy Markdown
Member Author

Managed to fix the "invisible wearables" bug when unlodding an avatar bug in this same PR

Copy link
Copy Markdown
Contributor

@sandrade-dcl sandrade-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer reproduce the bug of some avatars that stayed with the LOD sprite even if we were near of them.

I think we have to improve the transition between LOD sprites and the 3D models of the avatars, we should review the correct distance with the other avatars to activate/deactivate their LODs, and we should resolve the problem of seeing farest avatars moving with the LOD sprite without any animation. But I know itill be workd that we will be contemplating on future steps, so good work, this feature is taking shape! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants