Merged
Conversation
…art of website logic now
Contributor
|
After the CI passes:
|
AjimenezDCL
approved these changes
Jul 27, 2021
| DataStore.i.HUDs.loadingHUD.message.Set(payload.message); | ||
| DataStore.i.HUDs.loadingHUD.showWalletPrompt.Set(payload.showWalletPrompt); | ||
| // mendez: showWalletPrompt no longer needs to exist | ||
| DataStore.i.HUDs.loadingHUD.showWalletPrompt.Set(false); |
Contributor
There was a problem hiding this comment.
We should completly remove the wallet prompt.
I'm creating a ticket for this so we dont block this PR.
https://app.zenhub.com/workspaces/unity-6047bad476c3c0001942ee91/issues/decentraland/unity-renderer/851
Contributor
|
Strange, I remember reviewing this already. Anyway, looks good! |
…ity-renderer into chore/website-decoupling
pravusjif
approved these changes
Jul 27, 2021
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity counterpart of decentraland/explorer#2473
showWalletPromptfrom JSONDeactivateRenderingACKto signal kernel when the renderer should be fisabledSendAuthenticationsince it is handled by kernel now