Conversation
# Conflicts: # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/Tests/BuilderInWorldTest.asmdef
refactor: biw refactor part 1
# Conflicts: # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/BIWMainController.cs # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/Controllers/BIWSaveController.cs # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/States/EditorMode/BuilderInWorldGodMode.cs # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/Tests/BuilderInWorldTest.asmdef
AjimenezDCL
approved these changes
Jul 27, 2021
Contributor
AjimenezDCL
left a comment
AjimenezDCL
left a comment
There was a problem hiding this comment.
Looks good, left some comments!
sandrade-dcl
approved these changes
Jul 29, 2021
Contributor
sandrade-dcl
left a comment
sandrade-dcl
left a comment
There was a problem hiding this comment.
LGTM! I left some little comments/suggestions.
# Conflicts: # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/BuilderEntity/BIWEntity.cs # unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/BuilderMode/Catalog/BIWCatalogManager.cs
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds unit test for biw and some renames to be more consistent with the general naming of biw.
Also, some refactor has been made in order to make the code more easy to test
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md