fix: Sell item wrong URL#829
Merged
sandrade-dcl merged 3 commits intomasterfrom Jul 21, 2021
Merged
Conversation
Contributor
|
After the CI passes:
|
AjimenezDCL
approved these changes
Jul 20, 2021
Contributor
|
Haven't test the build, but codewise looks good! Left a small suggestion |
kuruk-mm
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix #145
When clicking sell CTA on any collectible item, it took the players to their assets URL on the marketplace when it should be taking them directly to the wearable URL instead.
Currently, the sell button takes you to
https://market.decentraland.org/accountand it needs to go tohttps://market.decentraland.org/contracts/[COLLECTION-SMART-CONTRACT]/tokens/[WEARABLE-TOKEN-ID]How to test the changes?
iicon of any wearable.Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md