Skip to content

fix: Sell item wrong URL#829

Merged
sandrade-dcl merged 3 commits intomasterfrom
fix/Sell-item-wrong-URL
Jul 21, 2021
Merged

fix: Sell item wrong URL#829
sandrade-dcl merged 3 commits intomasterfrom
fix/Sell-item-wrong-URL

Conversation

@sandrade-dcl
Copy link
Copy Markdown
Contributor

@sandrade-dcl sandrade-dcl commented Jul 20, 2021

What does this PR change?

Fix #145

When clicking sell CTA on any collectible item, it took the players to their assets URL on the marketplace when it should be taking them directly to the wearable URL instead.

Screen Shot 2020-08-31 at 10.16.01.png

Currently, the sell button takes you to https://market.decentraland.org/account and it needs to go to
https://market.decentraland.org/contracts/[COLLECTION-SMART-CONTRACT]/tokens/[WEARABLE-TOKEN-ID]

How to test the changes?

  1. Go to: https://play.decentraland.zone/index.html?renderer=urn:decentraland:off-chain:renderer-artifacts:fix/Sell-item-wrong-URL&ENV=org
  2. Open the AvatarEditorHUD.
  3. Go to Collectibles tab.
  4. Click on the i icon of any wearable.
  5. Click on the SELL button.
  6. Notice that you will be redirected to the correct wearable page.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@sandrade-dcl sandrade-dcl self-assigned this Jul 20, 2021
@github-actions
Copy link
Copy Markdown
Contributor

@AjimenezDCL
Copy link
Copy Markdown
Contributor

Haven't test the build, but codewise looks good! Left a small suggestion

Copy link
Copy Markdown
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works perfectly!

@sandrade-dcl sandrade-dcl merged commit 075663f into master Jul 21, 2021
@sandrade-dcl sandrade-dcl deleted the fix/Sell-item-wrong-URL branch July 21, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sell item wrong URL

3 participants