fix: Some scenes bug the character controller gravity#830
Merged
sandrade-dcl merged 1 commit intomasterfrom Jul 21, 2021
Merged
Conversation
Contributor
|
After the CI passes:
|
D4rWiNSS
approved these changes
Jul 21, 2021
kuruk-mm
approved these changes
Jul 21, 2021
Member
kuruk-mm
left a comment
kuruk-mm
left a comment
There was a problem hiding this comment.
Tested and it fixes the problem! Nice work!
sandrade-dcl
deleted the
fix/A-deployed-scene-bugs-the-character-controller-gravity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix #799
Some scenes are breaking the character controller gravity when jumping, letting us to make infinite jumps. See this video.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md