fix: Noticeable hiccups when receiving a chat message and the chat history is long#850
Merged
sandrade-dcl merged 4 commits intomasterfrom Jul 28, 2021
Conversation
Contributor
…at-message-and-the-chat-history-is-long
…at-message-and-the-chat-history-is-long
D4rWiNSS
approved these changes
Jul 28, 2021
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix #123
Seems to be that when the chat history gets quite long, every new chat message received takes some milliseconds in processing, and that causes noticeable hiccups
Main cause of the hiccups
Utils.ForceUpdateLayout(transform as RectTransform, delayed: false), that had having a huge impact on the performance when the chat had accumulated a lot of messages.scrollRect.verticalNormalizedPosition = 0, and it was affecting negatively to the performance.Implemented solutions
MAX_CHAT_ENTRIES) from100to30. It will make the HUD lighter.Metrics obtained from the
AddEntry(...)action hiccups~287.50msper each entry added in the chat.~3.45msper each entry added in the chat.How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md