chore: publish the code-coverage in its own step#853
Merged
Conversation
Contributor
|
After the CI passes:
|
pravusjif
approved these changes
Jul 27, 2021
menduz
reviewed
Jul 27, 2021
Member
menduz
left a comment
menduz
left a comment
There was a problem hiding this comment.
Why it is a different job? Can it be a step right at the end of the test pipeline? attaching the workspace and spinning new worker takes time
Member
Author
Ok! I will change it |
menduz
approved these changes
Jul 28, 2021
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #842
What does this PR change?
The code coverage now is published in another step to let the build finish and publish the artifacts even if the tests fail.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md