chore: trigger webhook from unity-renderer to gitlab after publish th…#856
Merged
chore: trigger webhook from unity-renderer to gitlab after publish th…#856
Conversation
Contributor
|
After the CI passes:
|
menduz
reviewed
Jul 27, 2021
menduz
reviewed
Jul 27, 2021
Co-authored-by: Agustin Mendez <github@menduz.com>
Co-authored-by: Agustin Mendez <github@menduz.com>
menduz
reviewed
Jul 27, 2021
Comment on lines
+392
to
+397
| # filters: | ||
| # branches: | ||
| # only: | ||
| # - master | ||
| # tags: | ||
| # only: /^\d+\.\d+\.\d+(.*)/ # npm tag + latest |
Member
There was a problem hiding this comment.
Suggested change
| # filters: | |
| # branches: | |
| # only: | |
| # - master | |
| # tags: | |
| # only: /^\d+\.\d+\.\d+(.*)/ # npm tag + latest |
This may not be added next commit. The if in the publish.ts does the trick for us.
kuruk-mm
force-pushed
the
chore/trigger-gitlab-pipeline
branch
from
b4e15fb to
5ba6d09
Compare
menduz
approved these changes
Jul 28, 2021
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e npm package
Resolves #852
What does this PR change?
Trigger gitlab pipeline after publish
How to test the changes?
Check if the pipeline triggers the gitlab webhook
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md