refactor: AssetBundle and GLTF AssetLibrary#857
Merged
Conversation
added 2 commits
July 27, 2021 16:27
… into refactor/ab-gltf-asset-library-pools
Contributor
|
After the CI passes: |
BrianAmadori
approved these changes
Jul 30, 2021
Contributor
BrianAmadori
left a comment
BrianAmadori
left a comment
There was a problem hiding this comment.
LGTM. Tested it for a while and found no issues.
sandrade-dcl
approved these changes
Aug 2, 2021
| public class AssetLibrary_Poolable<AssetType> : AssetLibrary<AssetType> | ||
| where AssetType : Asset_WithPoolableContainer | ||
| { | ||
| private readonly string salt = null; |
Contributor
There was a problem hiding this comment.
What does "salt" mean? Maybe we could find a more descriptive name.
This was referenced Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to avoid the strange situation when an Asset Bundles and GLTF collide with each other in the pool while having the same id.