feat: fix issue with lands where you have "UpdateManager" permission#884
Merged
feat: fix issue with lands where you have "UpdateManager" permission#884
Conversation
Contributor
|
After the CI passes:
|
D4rWiNSS
changed the title
This was referenced Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR fixes an issue where if you have "UpdateManager" permissions on lands, it will fail.
Also, it solves a problem where if you have more than 5000 lands, it won't load
How to test the changes?
In order to test the changes, you should have a UpdateManager permissions from any land.
If you don't have that, you can just test that everything work as normally
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md