Skip to content

fix: only check for lands if the shortcut or panel is used#888

Merged
D4rWiNSS merged 1 commit intomasterfrom
fix/release-defensive-fix
Aug 2, 2021
Merged

fix: only check for lands if the shortcut or panel is used#888
D4rWiNSS merged 1 commit intomasterfrom
fix/release-defensive-fix

Conversation

@D4rWiNSS
Copy link
Copy Markdown
Contributor

@D4rWiNSS D4rWiNSS commented Aug 2, 2021

What does this PR change?

This PR is a defensive measure, if you have lots of lands the explorer will process a lot of information, this way we ensure to only process the information in case that you want to use builder-in-world

How to test the changes?

  1. Go to: https://play.decentraland.zone/index.html?renderer=urn:decentraland:off-chain:renderer-artifacts:fix/release-defensive-fix&ENV=org
  2. Try to use the biw shorcut ("K") in a land where you are operator
  3. You shouldn't have access until the query is done, try again after some seconds
  4. It should enter now

OR

  1. Go to: https://play.decentraland.zone/index.html?renderer=urn:decentraland:off-chain:renderer-artifacts:fix/release-defensive-fix&ENV=org
  2. Enter with a land that have a lots of lands
  3. Check that everything work as expected

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@D4rWiNSS D4rWiNSS self-assigned this Aug 2, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants