Skip to content

Publish without node-pty dependency#585

Merged
chrmarti merged 5 commits intomainfrom
chrmarti/familiar-chicken
Jul 13, 2023
Merged

Publish without node-pty dependency#585
chrmarti merged 5 commits intomainfrom
chrmarti/familiar-chicken

Conversation

@chrmarti
Copy link
Copy Markdown
Contributor

@chrmarti chrmarti commented Jul 4, 2023

@chrmarti chrmarti force-pushed the chrmarti/familiar-chicken branch 2 times, most recently from dd65fec to 9cc516f Compare July 4, 2023 13:10
@chrmarti chrmarti force-pushed the chrmarti/familiar-chicken branch from 04065df to 1b0bcc2 Compare July 12, 2023 08:35
@chrmarti chrmarti force-pushed the chrmarti/familiar-chicken branch from 1b0bcc2 to 1161f39 Compare July 12, 2023 08:38
@chrmarti chrmarti changed the title Optional node-pty Publish without node-pty dependency Jul 12, 2023
@chrmarti chrmarti marked this pull request as ready for review July 13, 2023 12:33
@chrmarti chrmarti requested a review from a team as a code owner July 13, 2023 12:33
Copy link
Copy Markdown
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think this will require some extra testing in Codespaces once published. Do you anticipate any other changes we'll need to make to pick this up?

@chrmarti
Copy link
Copy Markdown
Contributor Author

@joshspicer From what I saw you install node-pty separately before you install the CLI and I think that might make everything continue to work as before. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants