Skip to content

Question: how to go about making PR's regarding my changes #732

@0wnlife

Description

@0wnlife

Hey maintainers,

This is my first time contributing, so I wanted to know how to go about making a PR.
Because I kept running into some pet-pieves, so I thought I'd implement a few of them (see below).

Please let me know how you would like me to continue.

With kind regards,
- 0wn


Container name: add-name-impl

Which are mentioned in the following issues:

Although these issues are not a 100% match, they are requesting/mentioning wanting to be able to set/use container names. Since the spec already has a name in the devcontainer.json and it was easily obtainable via the config, I've simply made use of it by then adding the --name <config.name> to the docker/podman command.

devcontainers/spec

devcontainers/cli


Commands stop/down: add-stop-down-command-impl

Which are mentioned in the following issues:

devcontainers/cli

devcontainers/spec


Node LTS 20 -> LTS 24: update-node-lts-24

and while I was at it I've also updated node to the latest LTS version (24), because node 20 support will end pretty soon based on their release schedule


Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions