Skip to content

Avoid nesting Block objects for quasisep kernels #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markfortune wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

Avoid nesting Block objects for quasisep kernels #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
399fa14
Avoid nesting Block objects for quasisep kernels
markfortune Apr 10, 2026
59e6bc6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/tinygp/kernels/quasisep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,13 @@ def coord_to_sortable(self, X: JAXArray) -> JAXArray:
return self.kernel1.coord_to_sortable(X)

def _block_or_dense(self, m1: JAXArray, m2: JAXArray) -> JAXArray:
if self.use_block:
return Block(m1, m2)
return jsp_block_diag(m1, m2)
if not self.use_block:
return jsp_block_diag(m1, m2)

# Ensure we don't nest Block objects to fix Issue #265
blocks1 = m1.blocks if isinstance(m1, Block) else (m1,)
blocks2 = m2.blocks if isinstance(m2, Block) else (m2,)
return Block(*blocks1, *blocks2)

def design_matrix(self) -> JAXArray:
return self._block_or_dense(
Expand Down