Drop pre-NodeJS 20.x support and add support for NodeJS 24.x and Fix broken tests by crespowang · Pull Request #1867 · dherault/serverless-offline

crespowang · 2025-11-24T00:01:28Z

Description

Investigated Test Failures

Problem: Tests were failing with "Unauthorized" errors when running npm test

Root Cause Discovered:

Serverless Framework v4 uses a compiled binary (Go) instead of pure JavaScript
The binary makes HTTP requests to https://core.serverless.com/api for authentication
Nock mocks don't work because they can only intercept requests in the same Node.js
process, not external binaries
The mock API key approach was fundamentally broken

Solution: Switched to using real Serverless API keys for testing

Removed Node.js 14, 16, and 18 Support 🗑️

AWS only supports NodeJS 20+

Key Changes:

src/config/supportedRuntimes.js: Removed nodejs14.x, nodejs16.x, nodejs18.x from
supported runtimes
- Now only supports: Node.js 20, 22, and 24
src/config/constants.js: Updated DEFAULT_LAMBDA_RUNTIME from nodejs14.x → nodejs20.x
.github/workflows/nodejs.yml: Updated CI matrix to test only Node.js 20, 22, 24
package.json: Updated minimum Node version: >=18.12.0 → >=20.0.0
Deleted: tests/integration/docker/nodejs/{nodejs14.x,nodejs16.x,nodejs18.x}/ directories
Updated: 71 serverless.yml files changed runtime: nodejs14.x/16.x/18.x → runtime:
nodejs20.x

Implemented Real API Key Authentication

Problem: Tests needed a way to authenticate with Serverless Framework v4

Solution Implemented:

A. Added Pre-Test Validation (tests/mochaHooks.cjs)

Checks if SERVERLESS_ACCESS_KEY environment variable is set before any tests run
If not set: immediately exits with process.exit(1) and displays helpful error message
Prevents cascading errors from running tests without authentication

B. Updated Test Setup (tests/_testHelpers/setupTeardown.js)

Removed hardcoded MOCK_ACCESS_KEY
Now reads SERVERLESS_ACCESS_KEY from environment
Removed nock mock setup (no longer needed)
Simplified code with comment explaining validation happens in mochaHooks

C. Updated CI Workflow (.github/workflows/nodejs.yml)

Added SERVERLESS_ACCESS_KEY: ${{ secrets.SERVERLESS_ACCESS_KEY }} to environment
Requires GitHub repository secret to be configured

D. Cleaned Up Unused Files

Deleted: tests/_testHelpers/serverlessApiMockSetup.cjs (non-functional nock mock)
Removed: Unused join import from desm package

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

This commit modernizes the codebase to support only Node.js 20+ and fixes test failures caused by Serverless Framework v4's authentication mechanism. ## Summary of Changes ### 1. Removed Node.js 14, 16, and 18 Support (78 files modified) - Update supported runtimes to Node.js 20, 22, and 24 only - Remove nodejs14.x, nodejs16.x, nodejs18.x from supportedRuntimes - Update DEFAULT_LAMBDA_RUNTIME from nodejs14.x to nodejs20.x - Update package.json minimum Node version: >=18.12.0 → >=20.0.0 - Update CI workflow to test only Node.js 20, 22, 24 - Delete nodejs14.x, nodejs16.x, nodejs18.x test directories - Update 71 serverless.yml files to use nodejs20.x runtime ### 2. Fixed Test Authentication for Serverless Framework v4 **Root Cause**: Serverless v4 uses a compiled binary that makes HTTP requests for authentication. Nock mocks cannot intercept requests from external binaries, only from the same Node.js process. **Solution**: Require real SERVERLESS_ACCESS_KEY environment variable - Add pre-test validation in mochaHooks.cjs that exits immediately if key not set - Update setupTeardown.js to use SERVERLESS_ACCESS_KEY from environment - Remove non-functional nock mock setup (serverlessApiMockSetup.cjs) - Add SERVERLESS_ACCESS_KEY to GitHub Actions workflow (requires secret) - Display helpful error message with instructions when key is missing ### 3. Files Changed Core configuration: - src/config/supportedRuntimes.js - src/config/constants.js - package.json - .github/workflows/nodejs.yml Test infrastructure: - tests/mochaHooks.cjs (added validation) - tests/_testHelpers/setupTeardown.js (use real API key) - tests/_testHelpers/serverlessApiMockSetup.cjs (deleted) Configuration files: - 71 serverless.yml files updated across tests/, examples/, and integration tests - 2 markdown issue templates updated ### How to Run Tests Locally: ```bash # Option 1: Login with Serverless npx serverless login # Option 2: Set API key directly export SERVERLESS_ACCESS_KEY=your_key_here # Run tests npm test ``` In CI: Add SERVERLESS_ACCESS_KEY to GitHub repository secrets 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…o nodejs24

darkmavis1980 · 2025-11-27T16:28:27Z

Waiting for this PR to be merged as now I can't use serverless-offline with node.js 24, which is now officially supported by AWS

crespowang · 2025-12-01T00:44:55Z

@dherault Is there anything else need to be done to get this merged?

darkmavis1980 · 2025-12-01T10:12:22Z

I tested this branch and it seems to work fine for me, but there are 4 failing checks

darkmavis1980 · 2025-12-01T16:47:33Z

tests/_testHelpers/setupTeardown.js

          cwd: servicePath,
          env: {
-            SERVERLESS_ACCESS_KEY: "MOCK_ACCESS_KEY",
+            SERVERLESS_ACCESS_KEY: serverlessAccessKey,


Do you need to pass an actual serverless key here instead of using a mock?

Serverless Framework v4 uses a compiled binary (Go) instead of pure JavaScript
The binary makes HTTP requests to https://core.serverless.com/api for authentication
Nock mocks don't work because they can only intercept requests in the same Node.js
process, not external binaries so the mock API key approach was fundamentally broken

It wasn't ;) https://github.com/dherault/serverless-offline/actions/runs/12765648904

rukywe · 2026-02-05T12:07:07Z

Any hopes of getting this merged soon ? :(!

Samaze123 · 2026-02-05T13:10:21Z

Any hopes of getting this merged soon ? :(!

Just for info, if you change in the serverless.yml file runtime: nodejs22.x, it works with node 24.

darkmavis1980 · 2026-02-05T15:09:46Z

Any hopes of getting this merged soon ? :(!

Just for info, if you change in the serverless.yml file runtime: nodejs22.x, it works with node 24.

You shouldn't change it every time just to run it locally, you should set the appropriate version, so when you deploy it, it deploys with Node.js 24

darkmavis1980

Tested and it works fine, but there are still some tests failing

crespowang · 2026-02-09T23:59:10Z

Now that it is merged, what's the process to release?

feat: Add support for Node.js 24.x in Docker environment

d170c44

crespowang requested review from dherault and dnalborczyk November 24, 2025 00:01

crespowang self-assigned this Nov 24, 2025

crespowang changed the title ~~feat: Add support for Node.js 24.x~~ Drop pre-NodeJS 20.x support and add support for NodeJS 24.x and Fix broken tests Nov 24, 2025

crespowang added 3 commits November 24, 2025 12:34

Delete .claude/settings.local.json

add5ee9

add gitignore

03a07a8

Merge branch 'nodejs24' of github.com:dherault/serverless-offline int…

4449cfd

…o nodejs24

crespowang requested a review from DorianMazur November 27, 2025 10:10

darkmavis1980 reviewed Dec 1, 2025

View reviewed changes

crespowang requested review from daniel-cottone, medikoo, pgrzesik and suryarajendhran December 4, 2025 01:00

medikoo removed their request for review December 4, 2025 08:40

crespowang mentioned this pull request Dec 12, 2025

Nodejs 24 runtime support #1868

Open

sebastianupr approved these changes Feb 6, 2026

View reviewed changes

darkmavis1980 approved these changes Feb 7, 2026

View reviewed changes

crespowang merged commit f51fe41 into master Feb 7, 2026
5 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Drop pre-NodeJS 20.x support and add support for NodeJS 24.x and Fix broken tests#1867

Drop pre-NodeJS 20.x support and add support for NodeJS 24.x and Fix broken tests#1867
crespowang merged 5 commits intomasterfrom
nodejs24

crespowang commented Nov 24, 2025 •

edited

Loading

Uh oh!

darkmavis1980 commented Nov 27, 2025

Uh oh!

crespowang commented Dec 1, 2025

Uh oh!

darkmavis1980 commented Dec 1, 2025

Uh oh!

darkmavis1980 Dec 1, 2025

Uh oh!

crespowang Dec 1, 2025

Uh oh!

DorianMazur Feb 24, 2026

Uh oh!

rukywe commented Feb 5, 2026

Uh oh!

Samaze123 commented Feb 5, 2026

Uh oh!

darkmavis1980 commented Feb 5, 2026

Uh oh!

darkmavis1980 left a comment

Uh oh!

Uh oh!

crespowang commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

crespowang commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Investigated Test Failures

Removed Node.js 14, 16, and 18 Support 🗑️

Implemented Real API Key Authentication

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Uh oh!

darkmavis1980 commented Nov 27, 2025

Uh oh!

crespowang commented Dec 1, 2025

Uh oh!

darkmavis1980 commented Dec 1, 2025

Uh oh!

darkmavis1980 Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

crespowang Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

DorianMazur Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

rukywe commented Feb 5, 2026

Uh oh!

Samaze123 commented Feb 5, 2026

Uh oh!

darkmavis1980 commented Feb 5, 2026

Uh oh!

darkmavis1980 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

crespowang commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

crespowang commented Nov 24, 2025 •

edited

Loading