Skip to content

Algorithms for Crossing Numbers#744

Open
MarkToner wants to merge 15 commits intodigraphs:mainfrom
MarkToner:main
Open

Algorithms for Crossing Numbers#744
MarkToner wants to merge 15 commits intodigraphs:mainfrom
MarkToner:main

Conversation

@MarkToner
Copy link
Copy Markdown

Added functionality for computing the crossing number of digraphs, both actual values and upper and lower bounds.

Also added miscellaneous functionality to support this goal:

  • Generation of cubic and semicomplete digraphs
  • Checking if a digraph is cubic or semicomplete
  • Adding of an artificial vertex between two given edges
  • Computing of all three cycles and triangles in a digraph
  • Computing the size of the partitions of a complete multipartite digraph (I feel this was probably achievable before but I could not find the documentation for such a method).

All functionality has been tested, with all public-facing functionality documented.

@james-d-mitchell james-d-mitchell added the new-feature A label for new features. label Apr 7, 2025
@james-d-mitchell
Copy link
Copy Markdown
Member

@MarkToner looks like there's lots of good stuff in this PR, can you please fix the linting issues, and then we will give this a proper review? Thanks!

@james-d-mitchell james-d-mitchell added the waiting for creator input A label for issues/PRs where we are waiting for the creator to do something label Apr 7, 2025
@MarkToner
Copy link
Copy Markdown
Author

@james-d-mitchell Will do as soon as soon as possible!

Copy link
Copy Markdown
Collaborator

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a few changes that you must have committed by accident, which seem to be preventing tests from passing. Take a look at the lines I've commented on, and probably just revert them. That might get the last tests passing.

@mtorpey
Copy link
Copy Markdown
Collaborator

mtorpey commented Apr 8, 2026

I've merged this into my own crossing-numbers branch, and I'll see if we can review it bit by bit like we did with the edge weightings stuff. I'll start with some of the minor methods. :)

@james-d-mitchell
Copy link
Copy Markdown
Member

Good idea! Thanks @mtorpey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature A label for new features. waiting for creator input A label for issues/PRs where we are waiting for the creator to do something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants