Add __index__ fallback to mpz constructor (fixes #237)#238
Merged
skirpichev merged 8 commits intodiofant:masterfrom Aug 15, 2025
Merged
Add __index__ fallback to mpz constructor (fixes #237)#238skirpichev merged 8 commits intodiofant:masterfrom
skirpichev merged 8 commits intodiofant:masterfrom
Conversation
skirpichev
reviewed
Aug 15, 2025
skirpichev
reviewed
Aug 15, 2025
Contributor
Author
|
@skirpichev should I create a new file of test cases for this update? |
skirpichev
reviewed
Aug 15, 2025
skirpichev
reviewed
Aug 15, 2025
Member
No, you could add tests like for a case with |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add index fallback to mpz constructor (fixes #237)
Problem
The
mpzconstructor only supports objects with__int__()method, failing with objects that only implement__index__().Solution
Added fallback mechanism that:
__int__()first (maintains backward compatibility)__index__()if__int__()not availableChanges
new_implfunction inmain.cto add__index__()fallback