Add pre-commit

[rruuaanng]

No description provided.

[rruuaanng]

As far as I know, only clang-format currently supports formatting of C. Personally, I think we don't need it, just like cpython doesn't use it yet.

[rruuaanng]

It's Looks fine!

PS E:\code\github\python-gmp> git commit -m 'Add pre-commit'
Run ruff on tests/...................................(no files to check)Skipped
Sphinx Lint..........................................(no files to check)Skipped
[add-pre-hook 8ba3d2c] Add pre-commit
 2 files changed, 27 insertions(+)
 create mode 100644 .github/workflows/linter.yml
 create mode 100644 .pre-commit-config.yaml

[rruuaanng]

cc @skirpichev Look this ;)

[rruuaanng]

What C style do you prefer? GNU style? or kernel style? Maybe we need to write our own clang-format, but I want to hear your desired style for this project.

[skirpichev]

What C style do you prefer? GNU style? or kernel style?

As this is a Python extension so far, I would choose PEP 7 style.

Please note, that pythoncapi_compat.h shouldn't be changed.

[rruuaanng]

Alright, I will complete this PR in the near future. Currently, CPython does not strictly enforce PEP 7, as clang often cannot accurately describe it. However, I will try to make sure the code complies with PEP7 as much as possible, which may take some time. Please do not rush me. Especially to launch PR without notice, I need to reiterate this point.

[rruuaanng]

Let us rejoice, now we have formatting tools!

[rruuaanng]

@skirpichev Please review them!

[skirpichev]

So, some comments.

Sorry, I'm not sure how to improve things.

[rruuaanng]

Maybe we should remove the style check of C. Clang cannot strictly implement PEP7, because it combines multiple practices.

And CPython has no requirements for this, and only gives change requirements at the review stage.

[rruuaanng]

I think it should be removed. At least there are only you and me participating in the current project. We just need to abide by it. @skirpichev

[skirpichev]

I think should also check *.yml and pyproject.toml.

[skirpichev]

It's readme says: "this action is in maintenance-only mode". I don't think we should depend on obsoleted project.

[skirpichev]

We should check all files, like current "test" action does. BTW, ruff test in the test.yml now redundant and should be removed.

[rruuaanng]

Valuable suggestions, I will revise them.

[skirpichev]

See #82