Open
Conversation
Member
Author
|
Still seeing this error:
Trying to see if I can fix it... |
This reverts commit 9b2ce08.
…. Also added the required libmambapy dependency. https://asv.readthedocs.io/en/stable/asv.conf.json.html#conda-environment-file
This reverts commit bd41fc8.
pauloxnet
approved these changes
Nov 5, 2024
pauloxnet
reviewed
Nov 5, 2024
Member
pauloxnet
left a comment
pauloxnet
left a comment
There was a problem hiding this comment.
I propose to use Python 3.12 and proposed small, non-blocking suggestions.
| uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' |
Member
There was a problem hiding this comment.
Suggested change
| python-version: '3.11' | |
| python-version: '3.12' |
It seems ASV support Python 3.12 since version 0.6.2.
| activate-environment: asv-bench | ||
| environment-file: environment.yml | ||
| - name: Install Requirements | ||
| run: pip install -r requirements.txt |
Member
There was a problem hiding this comment.
Suggested change
| run: pip install -r requirements.txt | |
| run: python -m pip install --requirement requirements.txt |
Using pip as module is a best practice, and also long form for attributes.
| asv machine --machine ubuntu-latest --yes | ||
| echo '```' >> $GITHUB_STEP_SUMMARY | ||
| asv continuous --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\ | ||
| asv continuous -E conda:asv-bench --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\ |
Member
There was a problem hiding this comment.
Suggested change
| asv continuous -E conda:asv-bench --interleave-processes -a processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\ | |
| asv continuous --environment conda:asv-bench --interleave-processes --attribute processes=2 --split --show-stderr 'HEAD^' 'HEAD' |\ |
Used long form attributes.
| uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' |
Member
There was a problem hiding this comment.
Suggested change
| python-version: '3.11' | |
| python-version: '3.12' |
See above.
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Install Requirements |
Member
There was a problem hiding this comment.
Suggested change
| - name: Install Requirements | |
| - name: Install Requirements | |
| run: python -m pip install --requirement requirements.txt |
See above.
I wasn't able to select the line below in the suggestions, but you can delete it.
Comment on lines
+3
to
+6
| - pip | ||
| - wheel | ||
| - conda-build | ||
| - libmambapy |
Member
There was a problem hiding this comment.
Suggested change
| - pip | |
| - wheel | |
| - conda-build | |
| - libmambapy | |
| - conda-build | |
| - libmambapy | |
| - pip | |
| - wheel |
I only sorted dependencies, it can help in managing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASV 0.6.4 is released. https://pypi.org/project/asv/0.6.4/