Conversation
|
Hi Adam. I just approved the workflow to run just for you to test it. When you are ready you can tell me to take a look at the pr |
|
Some tests are failiing due to pysteps not being available for Python 3.14 - I'll therefore remove this python version from the test matrix. |
|
@elbdmi Please approve it again. |
|
@elbdmi This is ready for a review. Note that macos was removed due to pysteps being incompatible with modern mac chips. |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up conda | ||
| uses: conda-incubator/setup-miniconda@v3 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| channels: conda-forge,defaults | ||
| channel-priority: strict | ||
| activate-environment: sunflow | ||
| - name: Install pysteps via conda | ||
| shell: bash -el {0} | ||
| run: conda install -y pysteps |
There was a problem hiding this comment.
I would avoid using conda altogether. Especially in the pipeline, because it's very slow. In the instructions we have described how to use it with pdm so testing with that is probably preferable. However, using uv instead would speed it even more up, and thereby we will spend less time on GitHub Actions.
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: |
There was a problem hiding this comment.
Would be good to run this on tags also.
| matrix: | ||
| python-version: ["3.12", "3.13"] | ||
| # pysteps do not support mac with Apple chips | ||
| os: [ubuntu-latest, windows-latest] |
There was a problem hiding this comment.
@irenelivia @elbdmi, we have to discuss if we want to or aim to support Windows also. I don't mind at all, it's just that the production environment we are targeting is Linux only, but it could be both x86 and ARM in the future. However, for now we can just put it in.
3 participants
Related to #5
I took a first stab at creating a test workflow for the package.
Since I don't have mataintainers rights to this repo, it is hard for me to test that it works.
Note, I've added a dummy example test file called
test_example.py.