Add $collStats aggregation stage tests#144
Open
danielfrankcom wants to merge 6 commits intodocumentdb:mainfrom
Open
Add $collStats aggregation stage tests#144danielfrankcom wants to merge 6 commits intodocumentdb:mainfrom
danielfrankcom wants to merge 6 commits intodocumentdb:mainfrom
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
sathvikprasad97
suggested changes
Apr 28, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
sathvikprasad97
approved these changes
Apr 28, 2026
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (2270+53 LOC, 19 files); LLM: Adds new test coverage for the $collStats aggregation stage, including new assertion machinery for complex result structures; touches test files and result-analyzer logic but is scoped to the test-coverage component. If a label is wrong, remove it manually and ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$collStatsoperator.Due to the nature of the operator, I needed to take a different approach to the assertions here. We can't reliably capture the entire expected shape of the result, so I added some machinery for asserting properties of the result. This should let us provide the coverage we need for
$collStats, but also be applicable to future operators with complex results structures.I also tried to avoid implementation-specific logic, since these stats seem to expose different things depending on the engine internals. The tests here are focused on the operator spec as best as possible.
I had to move
strict_equalto its own module to avoid a circular import issue. The content is exactly the same, I just pulled it out.